Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-image): Correctly calculate aspect ratio when width and height are both set #30466

Merged
merged 1 commit into from
Mar 26, 2021
Merged

fix(gatsby-plugin-image): Correctly calculate aspect ratio when width and height are both set #30466

merged 1 commit into from
Mar 26, 2021

Conversation

ascorbic
Copy link
Contributor

When width and height are both set we weren't returning the calculated aspect ratio. This is needed in generateLowResolutionImageURL.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 25, 2021
@LekoArts LekoArts added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 26, 2021
@ascorbic ascorbic added this to To cherry-pick in V3 Release Hotfixes via automation Mar 26, 2021
laurieontech
laurieontech approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last time

@ascorbic ascorbic merged commit 35c90f8 into master Mar 26, 2021
@ascorbic ascorbic deleted the fix/helper-aspect-ratio branch March 26, 2021 16:47
@gatsbybot gatsbybot mentioned this pull request Mar 29, 2021
Merged
wardpeet pushed a commit that referenced this pull request Mar 29, 2021
@ascorbic @wardpeet
fix(gatsby-plugin-image): Correctly calculate aspect ratio when width…
81d5797 
… and height are both set (#30466)

(cherry picked from commit 35c90f8)
@wardpeet wardpeet moved this from To cherry-pick to Backport PR opened in V3 Release Hotfixes Mar 29, 2021
@wardpeet wardpeet moved this from Backport PR opened to To cherry-pick in V3 Release Hotfixes Mar 29, 2021
@wardpeet wardpeet moved this from To cherry-pick to Backport PR opened in V3 Release Hotfixes Mar 29, 2021
wardpeet pushed a commit that referenced this pull request Mar 29, 2021
@ascorbic
fix(gatsby-plugin-image): Correctly calculate aspect ratio when width…
95cf933 
… and height are both set (#30466) (#30529)

(cherry picked from commit 35c90f8)

Co-authored-by: Matt Kane <matt@gatsbyjs.com>
@wardpeet wardpeet moved this from Backport PR opened to Backported in V3 Release Hotfixes Mar 30, 2021
@vladar vladar moved this from Backported to Archived in V3 Release Hotfixes Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurieontech laurieontech laurieontech approved these changes

Assignees
No one assigned
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
No open projects
V3 Release Hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ascorbic @laurieontech @LekoArts