Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-image): Apply object-fit and object-position to placeholder #30894

Merged
merged 1 commit into from
Apr 16, 2021
Merged

fix(gatsby-plugin-image): Apply object-fit and object-position to placeholder #30894

merged 1 commit into from
Apr 16, 2021

Conversation

ascorbic
Copy link
Contributor

Apply the objectFit and objectPosition properties to the placehodler as well as the main image. Fixes #30841

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 16, 2021
@ascorbic ascorbic added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 16, 2021
@ascorbic ascorbic merged commit 8affcf5 into master Apr 16, 2021
@ascorbic ascorbic deleted the fix/placeholder-object-fit branch April 16, 2021 11:31
@ascorbic ascorbic added this to To cherry-pick in V3 Release Hotfixes via automation Apr 16, 2021
vladar pushed a commit that referenced this pull request Apr 19, 2021
@ascorbic @vladar
fix(gatsby-plugin-image): Apply object-fit and object-position to pla…
9b6f701 
…ceholder (#30894)

(cherry picked from commit 8affcf5)
@gatsbybot gatsbybot mentioned this pull request Apr 19, 2021
Merged
@vladar vladar moved this from To cherry-pick to Backport PR opened in V3 Release Hotfixes Apr 19, 2021
vladar pushed a commit that referenced this pull request Apr 19, 2021
@ascorbic
fix(gatsby-plugin-image): Apply object-fit and object-position to pla…
2ee989c 
…ceholder (#30894) (#30944)

(cherry picked from commit 8affcf5)

Co-authored-by: Matt Kane <matt@gatsbyjs.com>
@vladar vladar moved this from Backport PR opened to Backported in V3 Release Hotfixes Apr 19, 2021
@vladar
Copy link
Contributor

vladar commented Apr 19, 2021

Published in gatsby-plugin-image@1.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
No open projects
V3 Release Hotfixes
Backported
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gatsby-plugin-image object-fit is not reflected on placeholder
3 participants
@ascorbic @vladar @LekoArts