Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-image): add @babel/core peer dependency #31188

Merged
merged 1 commit into from
May 3, 2021
Merged

fix(gatsby-plugin-image): add @babel/core peer dependency #31188

merged 1 commit into from
May 3, 2021

Conversation

MorrisonCole
Copy link
Contributor

@MorrisonCole MorrisonCole commented May 2, 2021 •
edited

Description

When resolving the dependencies of a project using gatsby-plugin-image with Yarn 2, the following warning is printed:

➤ YN0002: │ gatsby-plugin-image@npm:1.4.0 [558ef] doesn't provide @babel/core (p64f0e), requested by babel-plugin-remove-graphql-queries

This adds the peer dependency as recommended by Yarn.

Related Issues

Related to #20949.

Note to watchers

You can work around this warning in your projects by adding this to your .yarnrc.yml in the meantime:

packageExtensions:
  # awaiting fix: https://github.com/gatsbyjs/gatsby/pull/31188
  'gatsby-plugin-image@*':
    peerDependenciesMeta:
      '@babel/core':
        optional: true

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 2, 2021
@MorrisonCole MorrisonCole changed the title fix(gatsby-plugin-typescript): add babel peer dependency for Yarn 2 fix(gatsby-plugin-typescript): add @babel/core peer dependency for Yarn 2 May 2, 2021
@MorrisonCole MorrisonCole changed the title fix(gatsby-plugin-typescript): add @babel/core peer dependency for Yarn 2 fix(gatsby-plugin-typescript): add @babel/core peer dependency May 2, 2021
@MorrisonCole MorrisonCole changed the title fix(gatsby-plugin-typescript): add @babel/core peer dependency fix(gatsby-plugin-image): add @babel/core peer dependency May 2, 2021
@LekoArts LekoArts added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 3, 2021
LekoArts
LekoArts approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LekoArts LekoArts merged commit f4c1130 into gatsbyjs:master May 3, 2021
@MorrisonCole MorrisonCole deleted the fix/gatsby-plugin-image-peer-dependencies branch May 4, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MorrisonCole @LekoArts