fix(wordpress-source-plugin): create nodes properly for images who exceed maxFileSizeBytes

[veryspry]

Description

The WordPress source plugin was returning incorrectly formatted node data for page/post featuredImages whose size exceeded the maxFileSizeBytes config option. The result of this was that the featuredImage.node field would be set to null and not return other relevant info about the featured image.

This means that a query for allWpPost or allWpPage will no longer return this result:

"allWpPost": {
      "nodes": [
        {
          "id": "cG9zdDo1",
          "featuredImage": {
            // this isn't great because we don't know important info like at what url this resource can be found at
            "node": null
          }
        },
      ]
    }

"allWpPost": {
      "nodes": [
        { at
          "id": "cG9zdDo1",
          "featuredImage": {
            // now important node information is returned
            "node": {
              "id": "cG9zdDo2",
              "sourceUrl": "http://wordpresssite.com/wp-content/uploads/2021/05/picture-scaled.jpg",
              "localFile": null
            }
          }
        },
      ]
    }

Related Issues

Fixes #30755

[TylerBarnes]

Awesome work! 🙌 just a couple tiny changes then LGTM!

[TylerBarnes]

Looking awesome, just a few small things 😄

[TylerBarnes]

@veryspry looks like the snapshots need to be updated. For these tests I usually just delete the snapshots and run the tests again since the test npm script is a bit awkward to run with --updateSnapshot

[veryspry]

@veryspry looks like the snapshots need to be updated. For these tests I usually just delete the snapshots and run the tests again since the test npm script is a bit awkward to run with --updateSnapshot

Weird, I thought I already did that, but I must have changed the site structure to accommodate one of the most recent assertions 🤔

Anyways, snapshots have been updated!

[TylerBarnes]

Looks great :D thanks again for this!