chore: don't crash child process when reporter is used #31812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
vladar
removed
the
status: triage needed
pieh
force-pushed
the
pieh/reporter-in-worker-doesnt-crash
branch
from
13a4be3
to
c699a8f
Compare
pieh
force-pushed
the
pieh/reporter-in-worker-doesnt-crash
branch
from
c699a8f
to
52157ae
Compare
LekoArts
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Temporary workaround for worker crashes when reported is used in worker. For now logs are discarded (for IPC), but eventually we will need a way to properly handle logs originating in worker processes.