fix(gatsby-source-wordpress) Use send property for timeout (#31737) #31847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errides for timeouts (gatsbyjs#31737)
gatsbot
bot
added
the
status: triage needed
TylerBarnes
added
status: needs core review
TylerBarnes
added
topic: source-wordpress
TylerBarnes
requested changes
Jun 11, 2021
There was a problem hiding this comment.
Thanks for this @ThyNameIsMud ! Just one small change request
...gatsby-source-wordpress/src/steps/source-nodes/create-nodes/create-remote-file-node/index.js
Outdated
Show resolved
Hide resolved
...gatsby-source-wordpress/src/steps/source-nodes/create-nodes/create-remote-file-node/index.js
Show resolved
Hide resolved
TylerBarnes
approved these changes
Jun 11, 2021
TylerBarnes
added
the
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates remote node fetch to use the
sendpropety for timeout and adds overrides for timeouts (#31737)Description
When a remote node is fetched by
gotthere are competing timeouts that will cause the fetch to fail, and therefore, builds to fail due to requests being queued by the socket or the hosting service (i.e., AWS).The plugin relies on a retry method for
gotto retry the request for specific status codes and network errors, however,gotdoes not use this method for streams.The change allows overriding of the
CONNECTION_TIMEOUT,STALL_TIMEOUT, andSTALL_RETRY_LIMITvariables using the same environment variables used by gatsby-source-filesystem.Additionally, the change updates the timeout property used for
gotto reference thesendtimeout instead. The CONNECT_RETRY was removed since it's not being applied at all.Documentation
GOT Timeouts: https://github.com/sindresorhus/got/tree/v11.7.0#timeout
GOT Retries: https://github.com/sindresorhus/got/tree/v11.7.0#retry
Related Issues
#31737