fix(gatsby-source-wordpress): don't leak auth details #32303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
added
topic: source-wordpress
|
@TylerBarnes I'm unsure why snapshots changed, I looked into the Wordpress instance and it has multiple menus so the new snapshot looks correct but unsure why |
TylerBarnes
approved these changes
Jul 9, 2021
There was a problem hiding this comment.
@wardpeet I think the reason is our docker WP instance might have a leftover wp-basic-auth plugin which can use the same basic auth headers. Menu items are private unless the menu they're a part of is set to a location. If you're authenticated as a user (which isn't normally possible in WP w/ basic auth unless you install the plugin I mentioned) then you can view these menu items. Looks like that's what's happening here. I think that's ok 👌
vladar
pushed a commit
that referenced
this pull request
Jul 9, 2021
(cherry picked from commit 4d7ec18)
vladar
pushed a commit
that referenced
this pull request
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gatsby-brower is present in the gatsby-source-wordpress plugin. Gatsby leaks all pluginOptions inside gatsby-browser even if they are unused.
We remove this private information.
Documentation
Related Issues