fix(gatsby-source-wordpress): WPGraphQL pageInfo is nullable, make sure we're not accessing hasNextPage on null #32369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
TylerBarnes
added
topic: source-wordpress
TylerBarnes
commented
Jul 14, 2021
| @@ -84,9 +84,11 @@ const paginatedWpNodeFetch = async ({ | |||
| } | |||
|
|
|||
| let { | |||
| [contentTypePlural]: { nodes, pageInfo: { hasNextPage, endCursor } = {} }, | |||
| [contentTypePlural]: { nodes, pageInfo }, | |||
There was a problem hiding this comment.
these look almost the same. Where this is different is we never get to the = {} value fallback since null is a value.
DanielSLew
approved these changes
Jul 14, 2021
TylerBarnes
added
the
bot: merge on green
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…re we're not accessing hasNextPage on null (gatsbyjs#32369)
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue @graysonhicks was debugging.
WPGraphQL's pageInfo field is nullable, so we need to make sure we're not accessing hasNextPage on null.