Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-image): Switch react-dom import to remove createRoot warning #32457

Merged
merged 1 commit into from
Jul 21, 2021
Merged

fix(gatsby-plugin-image): Switch react-dom import to remove createRoot warning #32457

merged 1 commit into from
Jul 21, 2021

Conversation

LekoArts
Copy link
Contributor

Description

The named imports were a bit over eager in the initial PR (#32378) so this switches it to default import via ReactDOM. We do the same in cache-dir/app.js.

Related Issues

Fixes #32451

[ch34846]

@LekoArts LekoArts added the topic: media Related to gatsby-plugin-image, or general image/media processing topics label Jul 21, 2021
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 21, 2021
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 21, 2021
@LekoArts LekoArts changed the title change named imports to default import to fix warning fix(gatsby-plugin-image): Switch react-dom import to remove createRoot warning Jul 21, 2021
@LekoArts LekoArts added this to To cherry-pick in V3 Release Hotfixes via automation Jul 21, 2021
vladar
vladar reviewed Jul 21, 2021
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe add some greppable comment like TODO: remove in v4?

pieh
pieh approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this follows what we do in https://github.com/gatsbyjs/gatsby/blob/29dedc398da4ba69257cf60e0e1400ebaea3c886/packages/gatsby/cache-dir/production-app.js I think we can merge it.

@pieh pieh merged commit 9595ccb into master Jul 21, 2021
@pieh pieh deleted the gatsby-plugin-image-fix-warning branch July 21, 2021 09:42
@gatsbybot gatsbybot mentioned this pull request Jul 21, 2021
Merged
LekoArts added a commit that referenced this pull request Jul 21, 2021
@LekoArts
fix(gatsby-plugin-image): Switch react-dom import to remove createRoo…
44ebf55 
…t warning (#32457)

(cherry picked from commit 9595ccb)
@LekoArts LekoArts moved this from To cherry-pick to Backport PR opened in V3 Release Hotfixes Jul 21, 2021
LekoArts added a commit that referenced this pull request Jul 21, 2021
@LekoArts
fix(gatsby-plugin-image): Switch react-dom import to remove createRoo…
a6fa7c7 
…t warning (#32457) (#32458)

(cherry picked from commit 9595ccb)

Co-authored-by: Lennart <lekoarts@gmail.com>
@LekoArts LekoArts moved this from Backport PR opened to Backported in V3 Release Hotfixes Jul 21, 2021
@LekoArts LekoArts moved this from Backported to Published in V3 Release Hotfixes Jul 21, 2021
@LekoArts
Copy link
Contributor Author

Published in gatsby-plugin-image@1.10.1

pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@ViCo0TeCH
fix(gatsby-plugin-image): Switch react-dom import to remove createRoo…
e505810 
…t warning (gatsbyjs#32457)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar left review comments

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
No open projects
V3 Release Hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gatsby-plugin-image]: Warning about createRoot after upgrading to 1.10.0
3 participants
@LekoArts @vladar @pieh