Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-plugin-image): add check for node.gatsbyImage in the getImage helper #35507

Merged
merged 4 commits into from
May 3, 2022
Merged

feat(gatsby-plugin-image): add check for node.gatsbyImage in the getImage helper #35507

merged 4 commits into from
May 3, 2022

Conversation

TylerBarnes
Copy link
Contributor

With Gatsby's new Image CDN feature we added a new GraphQL field gatsbyImage which is used in place of gatsbyImageData. This PR adds a check for that in the getImage helper.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 27, 2022
@TylerBarnes TylerBarnes added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 27, 2022
wardpeet
wardpeet previously approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test?

veryspry
veryspry previously approved these changes Apr 29, 2022
View reviewed changes
@TylerBarnes TylerBarnes dismissed stale reviews from veryspry and wardpeet via f5d9aa2 April 29, 2022 16:55
veryspry
veryspry approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@veryspry veryspry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me

@TylerBarnes TylerBarnes merged commit abc6dca into master May 3, 2022
@TylerBarnes TylerBarnes deleted the fix/get-image-for-image-cdn branch May 3, 2022 18:15
@snyk-bot snyk-bot mentioned this pull request May 10, 2022
Open
@Rutam21 Rutam21 mentioned this pull request May 10, 2022
Open
@MaxMood96 MaxMood96 mentioned this pull request May 10, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 10, 2022
Open
@kaocher82 kaocher82 mentioned this pull request May 10, 2022
Open
@Rutam21 Rutam21 mentioned this pull request May 10, 2022
Open
@0xSebin 0xSebin mentioned this pull request May 10, 2022
Open
@ajesse11x ajesse11x mentioned this pull request May 10, 2022
Open
@0xSebin 0xSebin mentioned this pull request May 10, 2022
Open
@saurabharch saurabharch mentioned this pull request May 10, 2022
Open
This was referenced May 10, 2022
Open
Open
This was referenced Nov 29, 2022
Open
Open
This was referenced Nov 29, 2022
Open
Open
@samq-ws samq-ws mentioned this pull request Nov 29, 2022
Open
This was referenced Nov 29, 2022
Open
Open
Open
This was referenced Feb 28, 2023
Open
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 28, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Mar 1, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Mar 16, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Mar 16, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2023
Open
@saurabharch saurabharch mentioned this pull request Mar 21, 2023
Open
This was referenced Mar 28, 2023
Open
Open
@snyk-bot snyk-bot mentioned this pull request Apr 10, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Apr 19, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2023
Open
@monizb monizb mentioned this pull request Apr 20, 2023
Open
@kaocher82 kaocher82 mentioned this pull request May 4, 2023
Open
@kaocher82 kaocher82 mentioned this pull request May 12, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request May 23, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Jun 16, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veryspry veryspry veryspry approved these changes

@wardpeet wardpeet Awaiting requested review from wardpeet

Assignees
No one assigned
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TylerBarnes @wardpeet @veryspry