chore: workaround lerna + npm-run-all weirdness #35595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
type: maintenance
|
@pieh can we ship this? I've run into the type problem again on the 4.14 release -.-' |
Yes, I think so - I'm just sure if this is the root of the issue we are seeing |
LekoArts
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref: lerna/lerna#2145 (comment)
npm-run-allinteracts "weirdly" with lerna and I suspect that script like thisgatsby/packages/gatsby-sharp/package.json
Line 40 in 4e415cc
is causing to (re)run
buildscript on every package in monorepo (as under the hood it runslerna run build)The weirdness doesn't happen always (confusing), but I can definitely see weird, duplicated output when publishing