Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gatsby-link 4.19.0 shipped without types #36198

Closed
2 tasks done
aaronadamsCA opened this issue Jul 21, 2022 · 0 comments · Fixed by #36199
Closed
2 tasks done

gatsby-link 4.19.0 shipped without types #36198

aaronadamsCA opened this issue Jul 21, 2022 · 0 comments · Fixed by #36199
Labels
status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) type: bug An issue or pull request relating to a bug in Gatsby

Comments

@aaronadamsCA
Copy link
Contributor

aaronadamsCA commented Jul 21, 2022

Preliminary Checks

Description

gatsby-link 4.18.0 contained an index.d.ts: https://unpkg.com/gatsby-link@4.18.0/index.d.ts

This file is missing in 4.19.0: https://unpkg.com/gatsby-link@4.19.0/index.d.ts

But package.json still references it: https://unpkg.com/gatsby-link@4.19.0/package.json

As a result, import { navigate } from "gatsby" is untyped.

Reproduction Link

Can provide if needed

Steps to Reproduce

  1. import { navigate } from "gatsby" into a TypeScript project

Expected Result

navigate works normally

Actual Result

error: Unsafe call of an `any` typed value (@typescript-eslint/no-unsafe-call)

Environment

`gatsby` v4.19.1 with `gatsby-link` v4.19.0

Config Flags

No response

@aaronadamsCA aaronadamsCA added the type: bug An issue or pull request relating to a bug in Gatsby label Jul 21, 2022
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 21, 2022
@LekoArts LekoArts added status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants