fix(gatsby-plugin-mdx): Default remark node to span #37423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
tyhopp
removed
the
status: triage needed
LekoArts
approved these changes
Jan 9, 2023
Closed
2 tasks
leobang17
added a commit
to leobang17/gatsby-theme-simplex
that referenced
this pull request
Mar 11, 2023
- gatsby-plugin-mdx 의존성 최신버전으로 업데이트 - 기존의 파서가 `` inline code를 <span> tag가 아닌 <div> tag로 변환하고 있었음. - gatsbyjs/gatsby#37423 - 해당 PR을 통해 정상적으로 고쳐짐 -> 해당 버전으로 업데이트 - codeblock theme을 위한 의존성 설치 - prism-themes - remark-gfm
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the wrapping element type we generate when handling html nodes from
divtospanso that remark plugins can handle inline elements.This avoids situations where the generated
divbecomes a child of elements with a phrasing content model like<p>, which is invalid HTML.Nice explanation of this I found - https://stackoverflow.com/questions/8397852/why-cant-the-p-tag-contain-a-div-tag-inside-it/34683474#34683474
Documentation
N/A
Related Issues
Resolves #37292