Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Netlify CMS plugin to replace webpack loader exclusions #4047

Closed
erquhart opened this issue Feb 15, 2018 · 2 comments
Closed

Update Netlify CMS plugin to replace webpack loader exclusions #4047

erquhart opened this issue Feb 15, 2018 · 2 comments
Assignees

Comments

@erquhart
Copy link
Contributor

erquhart commented Feb 15, 2018

#4046 will revert the changes introduced in #3611. The purposes of the commit being reverted as mentioned in the PR:

  • uses arrays when defining webpack loader.exclude so that exclusions may be added by plugins
  • adds node_modules/netlify-cms to css loader exclusions (build-javascript stage)

Since the exclusions will go back to being strings, we should be able to address this by passing a function to the webpack-configurator loader method to replace the string with an array and achieve the same result.

@KyleAMathews you can consider this assigned to me.

@KyleAMathews
Copy link
Contributor

👍

@KyleAMathews
Copy link
Contributor

Added you as a collaborator so you can assign stuff to yourself directly :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants