Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable eslint when a local .eslintrc is found in project #5763

Closed
kkemple opened this issue Jun 6, 2018 · 3 comments
Closed

Disable eslint when a local .eslintrc is found in project #5763

kkemple opened this issue Jun 6, 2018 · 3 comments
Assignees
@kkemple
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
Gatsby v2 Release

Comments

@kkemple
Copy link
Contributor

kkemple commented Jun 6, 2018 •
edited
Loading

When a user has eslint in the project we should not add eslint to the webpack config as it break things for the user.
@kkemple kkemple added the type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change label Jun 6, 2018
@kkemple kkemple added this to To Do - v2 in Gatsby v2 Release via automation Jun 6, 2018
@kkemple kkemple moved this from To Do - v2 to To Do - beta 1 in Gatsby v2 Release Jun 6, 2018
@kkemple kkemple self-assigned this Jun 6, 2018
@KyleAMathews
Copy link
Contributor

Is this a temp fix? I thought we decided we'd always do this + document our eslint config so people could use that as a base for their own if they wanted.

#5493 (comment)

@m-allanson m-allanson moved this from To Do - beta 1 to To Do - v2 in Gatsby v2 Release Jun 11, 2018
@kkemple
Copy link
Contributor Author

kkemple commented Jun 13, 2018

bad wording, it's not temporary, it's just only step 1 of the config work!

@kkemple kkemple mentioned this issue Jun 13, 2018
Merged
@m-allanson m-allanson moved this from To Do - v2 to In progress in Gatsby v2 Release Jun 13, 2018
@m-allanson m-allanson moved this from In progress to To Do - v2 in Gatsby v2 Release Jun 15, 2018
@KyleAMathews KyleAMathews moved this from To Do - v2 to In progress in Gatsby v2 Release Jun 17, 2018
@KyleAMathews
Copy link
Contributor

Fixed in #5871

Gatsby v2 Release automation moved this from In progress to Done Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkemple kkemple

Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
No open projects
Gatsby v2 Release
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KyleAMathews @kkemple