Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gatsby-image: add missing GatsbyImageProps to TS defs #8606

Merged
merged 1 commit into from
Sep 28, 2018
Merged

gatsby-image: add missing GatsbyImageProps to TS defs #8606

merged 1 commit into from
Sep 28, 2018

Conversation

msssk
Copy link
Contributor

@msssk msssk commented Sep 28, 2018

See React prop-types in index.js

pieh
pieh approved these changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @msssk!

@pieh pieh merged commit b6f0d62 into gatsbyjs:master Sep 28, 2018
@gatsbot
Copy link

gatsbot bot commented Sep 28, 2018

Holy buckets, @msssk — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

lipis added a commit to lipis/gatsby that referenced this pull request Sep 28, 2018
@lipis
Merge branch 'master' of github.com:gatsbyjs/gatsby into hooks
c072eac 
* 'master' of github.com:gatsbyjs/gatsby:
  chore(release): Publish
  fix: add missing html and body attributes from ssr apis to develop mode (gatsbyjs#8594)
  chore(www): bump gatsby version (gatsbyjs#8614)
  chore: upgrade Gatsby Version in Gatsbygram Readme (gatsbyjs#8604)
  fix(gatsby-dev-cli): wait for files to be copied before exiting (gatsbyjs#8387)
  fix: add missing GatsbyImageProps to TS defs (gatsbyjs#8606)
  chore: forgot frontmatter date change (gatsbyjs#8601)
  Add Hasura GraphQL engine example under third party (gatsbyjs#8584)
  blog: update incorrect post date (gatsbyjs#8600)
  Add gatsby-mdx-starter to the list of starters (gatsbyjs#8547)
  Draft graphiql doc (gatsbyjs#8599)
  Added redirect (gatsbyjs#8528)
  feat: provide fragments without gatsby-image (gatsbyjs#8459)
  updated CODEOWNERS (gatsbyjs#8591)
  Updates to sidebar (gatsbyjs#8539)
@msssk msssk deleted the ts-defs-update branch October 2, 2018 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msssk @pieh