New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct path argument #8628

Merged

DSchau merged 1 commit into gatsbyjs:master from DSchau:gatsby-dev-cli/path-fix

Sep 28, 2018

Contributor

DSchau commented Sep 28, 2018

This fixes an issue that manifested itself in CI.

(node:10110) UnhandledPromiseRejectionWarning: TypeError: Path must be a string. Received { resolve: [Function: resolve],
  normalize: [Function: normalize],

path (previously) referred to what is now filePath, but this wasn't refactored correctly. This is why you don't rename variables 🙃 (my fault!)


          fix: use correct path argument

59e64f0

DSchau requested a review from a team as a code owner

September 28, 2018 20:33

valin4tor approved these changes

View reviewed changes

Contributor

valin4tor left a comment

LGTM!

DSchau merged commit acb5293 into gatsbyjs:master

DSchau deleted the gatsby-dev-cli/path-fix branch

September 28, 2018 20:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment