gatsby new site from template don't work on ie 10

[abumalick]

Description

A fresh new site crashes on ie 10 because 'Set' (used in react-dom) is not polyfilled.

Steps to reproduce

open https://gatsby-freshinstall.netlify.com with ie10

(source: https://github.com/abumalick/gatsby-freshinstall )

or:

• create a new site with gatsby-cli
• deploy to netlify
• test deploy link with ie10

Expected result

javascript should load without error

(a polyfill should be included automatically by babel-env ?)

Actual result

'Set is undefined':

this is a screenshot of sentry from another project, tested with ie10 windows 7 on browserstack:

Other notes

I had a similar problem with redux-form including a polyfill for string.prototype.startsWith fixed the problem. ref: redux-form/redux-form#4126

I will add a polyfill for Set to my projects until this is fixed in gatsby.

Environment

(I am testing with browserstack)

gatsby info --clipboard

  System:
    OS: macOS High Sierra 10.13.6
    CPU: x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 8.12.0 - ~/.nvm/versions/node/v8.12.0/bin/node
    Yarn: 1.10.1 - /usr/local/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v8.12.0/bin/npm
  Browsers:
    Chrome: 70.0.3538.67
    Firefox: 62.0.3
    Safari: 12.0
  npmPackages:
    gatsby: ^2.0.19 => 2.0.29
    gatsby-image: ^2.0.15 => 2.0.16
    gatsby-plugin-manifest: ^2.0.5 => 2.0.5
    gatsby-plugin-offline: ^2.0.5 => 2.0.8
    gatsby-plugin-react-helmet: ^3.0.0 => 3.0.0
    gatsby-plugin-sharp: ^2.0.7 => 2.0.7
    gatsby-source-filesystem: ^2.0.4 => 2.0.5
    gatsby-transformer-sharp: ^2.1.4 => 2.1.4

[abumalick]

ie 9 and ie 10 are in the supported browser by default right ? https://github.com/gatsbyjs/gatsby/blob/master/.babel-preset.js#L13

[swashata]

Hi,

I don't know if gatsby and/or the babel preset provides polyfills by default. But this is surely a polyfill issue. Maybe you can try with https://polyfill.io/v2/docs/

[stefanprobst]

Do we need to set corejs option for babel-transform-runtime? Babel7 does not include those by default.

gatsby/packages/babel-preset-gatsby/src/index.js

Lines 64 to 68 in 4d5c5e0

	r(`@babel/plugin-transform-runtime`),
	{
	helpers: true,
	regenerator: true,
	},

[stefanprobst]

@DSchau Could you take a look at this? By default we target ["last 4 versions", "safari >= 7", "ie >= 9"] but don't include the corejs polyfills with the babel runtime.

[DSchau]

@stefanprobst sure; I'll take a look here in a bit. We've heard similar issues tangentially about the browserslist not being picked up, so want to investigate that!

[georg-malahov]

@DSchau, any updates on this issue so far? If you provide more info and share any new ideas on how we can fix this, I would probably provide you with the PR. Because IE10 issues are very critical for our company. Thanks in advance!

[abumalick]

I think adding this line at the beginning of gatsby-browser.js fixes this error.

import 'core-js/modules/es6.set';

[georg-malahov]

@abumalick @DSchau Manually adding import 'core-js/modules/es6.set'; polyfills to gatsby-browser.js is a workaround, but not real solution. As stated in gatsby docs on browser support it should have IE9+ available with browserslist.

Gatsby supports the same browsers as the current stable version of React.js which is currently IE9+ as well as the most recent versions of other popular browsers.

I think it should be fixed the way that core-js/modules/es6.set and other polyfills added automatically with respect to browserslist as it was designed.

[gatsbot]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! 💪💜

[gatsbot]

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

Thanks again for being part of the Gatsby community!

[thebarty]

This issue still exists with current versions

[cbetta]

Could someone explain to me how this can be solved with the mentioned workaround?

I added import 'core-js/modules/es6.set'; to gatbsy-browser.js but I'm still having issues.

[abumalick]

what is the first error message ?

[cbetta]

Still getting the same issue. The 'Set' one.

[abumalick]

Strange, for us it is working

Make sure the polyfills imports are in first position in gatsby-browser

We use these polyfills in our app:

import 'core-js/modules/es6.set'; // react-dom
import 'core-js/modules/es6.map'; // react-dom
import 'core-js/modules/es6.string.starts-with'; // redux-form
import 'raf/polyfill';

[MariuszDabrowski]

Having the same issue, has there been any other developments in regards to fixing this issue?

[cbetta]

Still running into issues with this. It seems like nothing from gatsby-browser-js is actually getting loaded into the browser. Not sure what might be causing this.

[gatsbot]

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

Thanks again for being part of the Gatsby community!