Loot desert temples & get to outer end islands #191

SnivyLlama · 2022-01-24T22:28:13Z

Main changes

New RavageDesertTemplesTask, runnable as @test temples, will search deserts for temples to loot
In BeatMinecraft2Task, if any desert temples are found, they will be looted for anything needed
LootContainerTask improvements, such as not looting armor with curse of binding
New GetToOuterEndIslandsTask, runnable as @test outer, will run BeatMinecraft2Task until it finds an end gateway, it will then get an ender pearl and blocks to pearl to the outer end islands.
New ConstructIronGolemTask, runnable as @test iron, will build an iron golem.
Can now get honeycombs, with REALLY BAD optimization.

Other changes

Added StorageHelper.getBrewingStandFuel() and BrewingStandSlot
Can get wither skeleton skulls.

…g to `@gamer` soon

No bugs found... yet...

Now it should work ok... as far as I know...

…tape These are amazing changes imo

Removed the unused imports in `LootContainerTask`

Github is weird so I have to do this in two parts

self explanitory!

src/main/java/adris/altoclef/tasks/container/LootContainerTask.java

src/main/java/adris/altoclef/tasks/misc/RavageDesertTemplesTask.java

src/main/java/adris/altoclef/tasks/speedrun/BeatMinecraft2Task.java

- Added ability to filter itemstacks in `LootContainerTask` using predicates - Removed curse of binding filter as the feature listed above can take care of that - Put duplicated code in both `RavageDesertTemplesTask` AND `LocateDesertTempleTask` in `WorldHelper`

SnivyLlama · 2022-01-24T23:03:20Z

Oh what the heck the commit formatted weird

Missed something

Updated so any screen handler works

Neater code (and the slightest bit optimized)

SnivyLlama · 2022-01-25T00:00:06Z

Aight all the suggestions are done

JamesGreen31

I didn't review all the files as I ran out of time, but here are my main suggestions. I will re-review after the requested changes are made. Try to keep it simple and avoid unnecessary steps. It can get you stuck later on.

If you feel the requested changes don't align, please let me know or dismiss the review.

JamesGreen31 · 2022-01-25T01:36:12Z

src/main/java/adris/altoclef/tasks/misc/GetToOuterEndIslandsTask.java

+
+    @Override
+    protected Task onTick(AltoClef mod) {
+        if (isFinished(mod)) {


I am not sure you need this here at all. If this is finished, it will end onTick anyway, so something else is going on if this was the solution to a problem.

I would remove this as it may cause unexpected problems

I mean sure

Wait would this cause a problem with isActive?

Nah, isActive is true when a task is running and false when it has been interrupted/replaced by another task.

JamesGreen31 · 2022-01-25T01:38:28Z

src/main/java/adris/altoclef/tasks/misc/GetToOuterEndIslandsTask.java

+        if (mod.getBlockTracker().anyFound(Blocks.END_GATEWAY)) {
+            if (!mod.getItemStorage().hasItemInventoryOnly(Items.ENDER_PEARL)) {
+                setDebugState("Getting an ender pearl");
+                return new CataloguedResourceTask(new ItemTarget(Items.ENDER_PEARL, 1));


This may already work just fine, so take this comment as a suggestion rather than a change requisition.

you may want to get the enderman hashmap from mob defence so that you can always find one. Could be wrong here.

Also, you should get more than 1 pearl. You don't know how many islands you will need to hop.

Not thinking longterm yet, just want to get to the outer end island

Don't enderman spawn everywhere in the outer islands? If you need pearls just find one there

JamesGreen31 · 2022-01-25T01:39:28Z

src/main/java/adris/altoclef/tasks/misc/GetToOuterEndIslandsTask.java

+                return new CataloguedResourceTask(new ItemTarget(Items.ENDER_PEARL, 1));
+            }
+            BlockPos gateway = mod.getBlockTracker().getNearestTracking(Blocks.END_GATEWAY).get();
+            int blocksNeeded = Math.abs(mod.getPlayer().getBlockY() - gateway.getY()) +


This was smart, although you should get at least 15 more blocks than needed. Experience has taught me that altoclef sometimes uses more blocks than it really needs. In these cases, it is good to have a backup.

I would change this

Why would it? Works perfectly fine for me. In fact, its using way less because of this sick new invention called walking on the ground so I feel like I'm already doing a backup

I guess the problem is what if the bot has pillared up but it doesn't have enough blocks or something, it will try to mine the pillar. If half way down the pillar the bot decides "we have enough!" that's a problem since it will get stuck looping. We want the bot to finish mining the pillar and gather some materials from the ground, and that's why we usually ask for extra blocks.

If you for sure don't need that and know it won't get stuck (even in edge cases) then that's fine lol

No it won't, because the amount of building materials it wants updates every time the bot changes block position so if mining the pillar moves it away from the gateway, it will still try to get more

JamesGreen31 · 2022-01-25T01:40:38Z

src/main/java/adris/altoclef/tasks/misc/GetToOuterEndIslandsTask.java

+            }
+            GoalAnd goal = makeGoal(gateway);
+            Debug.logMessage(mod.getPlayer().getBlockPos().toString());
+            if (!goal.isInGoal(mod.getPlayer().getBlockPos()) || !mod.getPlayer().isOnGround()) {


Out of curiosity, why re-invent the wheel? You could use Altoclef's built in gotoXZ and gotoY functions for this. I would change this.

I dunno I thought it would be fun and a bit more efficient since I'm allowing baritone to approach from any side

Also its fun to reinvent the wheel

agreed, it can be fun as heck

JamesGreen31 · 2022-01-25T01:41:29Z

src/main/java/adris/altoclef/tasks/misc/GetToOuterEndIslandsTask.java

+                setDebugState("Getting close to gateway...");
+                return null;
+            }
+            setDebugState("Throwing the pearl inside");


Come to think of it, why don't we throw the portal in from the ground? Why do we build to it at all? Altoclef is very good at calculating trajectories. I would suggest playing into its strengths to avoid building entirely if you can.

I was thinking this, but I wasn't sure on how to tell if we can even hit the gateway from the position we are at

Yeah there is no "parabola raycast" in yet (maybe should add one but oh well), so what you're doing is valid.

When the bot throws an ender pearl for the dragon fight it assumes there's nothing in the way and that it always will have a clear shot. Here it's different.

JamesGreen31 · 2022-01-25T01:43:05Z

src/main/java/adris/altoclef/tasks/misc/GetToOuterEndIslandsTask.java

+
+    @Override
+    public boolean isFinished(AltoClef mod) {
+        return WorldHelper.getCurrentDimension() == Dimension.END &&


I would have a flag for if it successfully completed entering the portal as well. Are end islands always 400 meters away? Again, take this comment as a suggestion rather than change requisition.

No, they're much longer but may as well be sure. I'll add a flag that's a good idea

Actually, I'm not 100% sure how to do that in the case that it fails, like if we suddenly teleport? That's probably as reliable as this solution

This seems fine. Minor changes, I'd use WorldHelper.inRangeXZ so it ignores your y position and a constant at the top of the file (ex. private static final int OUTER_END_ISLAND_START_RADIUS = 400 or a shorter name if you want)

Actually I did a bit of research and it starts around 1000 blocks away so I'll make it 800 just to be safe

JamesGreen31 · 2022-01-25T01:44:28Z

src/main/java/adris/altoclef/tasks/misc/GetToOuterEndIslandsTask.java

+        return "Going to outer end islands";
+    }
+
+    private GoalAnd makeGoal(BlockPos gateway) {


I don't understand the need for the offsets. IIRC, you mentioned this is to avoid getting stuck and/or hitting the bedrock. That sounds like a pearl recalculation to me. This may work, but it would be a good idea to think about why the first attempt failed. Sometimes duct tape solutions can cause further problems down the road. Since this works, take this as a suggestion.

Also removed random duct I didn't even know I had there

Forgot

Why didnt *this* commit?

This method checks if the chest at that position was ever opened

…eRuinedPortalsTask`

Just in case we need it... ;)

- Use `WorldHelper.isInRange` instead of `Vec3d.distanceTo` - Make the end island radius a public constant

When using `@gamer`, we won't take anything with curse of binding, for the future ;) Also we prioritize pickaxes (I think?) when ravaging desert temples And a little neat fix to a problem when ravaging ruined portals

If we get hit by a shulker and rise high in the sky, we don't wanna die once we fall OMG AS IM TYPING THIS I REALIZED THAT WATER BUCKETS ARE THE EASY SOLUTION Well may as well... right?

Runnable as `@test iron`

Because no

No seriously, it just sticks to one bee nest, I will definitely try to optimize it sometime in the future

Do I have OCD?

Because its easier to use `WorldHelper.isBlock(mod, pos, block)` over `mod.getWorld().getBlockState(pos).getBlock() == block`

BuildTools and others added 9 commits January 23, 2022 15:58

Added @test temples, a command that will loot desert temples. Comin…

9f6be59

…g to `@gamer` soon

Merge remote-tracking branch 'origin/main' into main

b267418

Added desert temple looting for @gamer

d4ddc4d

No bugs found... yet...

Fix a bunch of things with looting

538d312

Now it should work ok... as far as I know...

Won't loot stuff with curse of binding; added LootContainerTask duct …

353187c

…tape These are amazing changes imo

Remove unused imports

9a23608

Removed the unused imports in `LootContainerTask`

Merge branch 'gaucho-matrero:main' into main

30ae63b

Updating Playground for the get to outer end islands task

f422370

Github is weird so I have to do this in two parts

Other changes + get to outer end islands

4370c32

self explanitory!

TacoTechnica requested changes Jan 24, 2022

View reviewed changes

BuildTools added 4 commits January 24, 2022 17:06

Whoopsie

337f1d8

Missed something

Just in case

59ab1c0

Make LootContainerTask work with any container

58e8714

Updated so any screen handler works

Used shouldForce and removed duct tape

4fc5581

Neater code (and the slightest bit optimized)

SnivyLlama requested a review from TacoTechnica January 25, 2022 01:14

JamesGreen31 requested changes Jan 25, 2022

View reviewed changes

SnivyLlama added 11 commits January 24, 2022 20:25

Move GetToOuterEndIslandsTask /misc -> /movement

8591b8a

Also removed random duct I didn't even know I had there

Whoops

b3f8ea6

Forgot

What

5146dbb

Why didnt *this* commit?

Added method isUnopenedChest to WorldHelper

2399b7a

This method checks if the chest at that position was ever opened

Use WorldHelper.getUnopenedChest in BeatMinecraft2Task and `Ravag…

e5a7b3a

…eRuinedPortalsTask`

Added BrewingStandSlot

56016f0

Just in case we need it... ;)

Make StorageHelper.getBrewingStandFuel() return an int instead

fa38571

Minor changes

2928e44

- Use `WorldHelper.isInRange` instead of `Vec3d.distanceTo` - Make the end island radius a public constant

Don't take things with curse of binding + minor changes

33c1e32

When using `@gamer`, we won't take anything with curse of binding, for the future ;) Also we prioritize pickaxes (I think?) when ravaging desert temples And a little neat fix to a problem when ravaging ruined portals

Eat chorus fruit when almost out of levitation

bbc7dbe

If we get hit by a shulker and rise high in the sky, we don't wanna die once we fall OMG AS IM TYPING THIS I REALIZED THAT WATER BUCKETS ARE THE EASY SOLUTION Well may as well... right?

Merge branch 'gaucho-matrero:main' into main

a26341e

SnivyLlama added 11 commits January 26, 2022 10:04

Don't chorus fruit clutch if we have a water bucket

90483f6

Updating Playground for something...

0b60f6b

Added ConstructIronGolemTask

37db5a7

Runnable as `@test iron`

Don't loot out of range ruined portals

00c4572

Because no

Added CollectHoneycombTask (can definitely use optimization)

b8566a3

No seriously, it just sticks to one bee nest, I will definitely try to optimize it sometime in the future

Add honeycomb stuff to the task catalogue

4363273

Sorry that one thing bothered me

a641939

Do I have OCD?

Added WorldHelper.isBlock

27914f4

Because its easier to use `WorldHelper.isBlock(mod, pos, block)` over `mod.getWorld().getBlockState(pos).getBlock() == block`

Apply WorldHelper.isBlock to ConstructIronGolemTask

30a273d

Merge branch 'main' into main

d77a96f

Whoopsie

460c5c8

TacoTechnica merged commit 7b99d53 into gaucho-matrero:main Feb 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Loot desert temples & get to outer end islands #191

Loot desert temples & get to outer end islands #191

SnivyLlama commented Jan 24, 2022 •

edited

SnivyLlama commented Jan 24, 2022

SnivyLlama commented Jan 25, 2022

JamesGreen31 left a comment

JamesGreen31 Jan 25, 2022

JamesGreen31 Jan 25, 2022

SnivyLlama Jan 25, 2022

SnivyLlama Jan 25, 2022

TacoTechnica Jan 25, 2022

SnivyLlama Jan 25, 2022

JamesGreen31 Jan 25, 2022

SnivyLlama Jan 25, 2022

TacoTechnica Jan 25, 2022

SnivyLlama Jan 25, 2022

JamesGreen31 Jan 25, 2022

JamesGreen31 Jan 25, 2022

SnivyLlama Jan 25, 2022

TacoTechnica Jan 25, 2022

SnivyLlama Jan 25, 2022

JamesGreen31 Jan 25, 2022

SnivyLlama Jan 25, 2022

SnivyLlama Jan 25, 2022

TacoTechnica Jan 25, 2022

JamesGreen31 Jan 25, 2022

SnivyLlama Jan 25, 2022

TacoTechnica Jan 25, 2022

JamesGreen31 Jan 25, 2022

SnivyLlama Jan 25, 2022

SnivyLlama Jan 25, 2022

TacoTechnica Jan 25, 2022

SnivyLlama Jan 25, 2022

JamesGreen31 Jan 25, 2022

SnivyLlama Jan 25, 2022

Loot desert temples & get to outer end islands #191

Loot desert temples & get to outer end islands #191

Conversation

SnivyLlama commented Jan 24, 2022 • edited

Main changes

Other changes

SnivyLlama commented Jan 24, 2022

SnivyLlama commented Jan 25, 2022

JamesGreen31 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SnivyLlama commented Jan 24, 2022 •

edited