Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to ignore/exclude by class name #64

Closed
vorburger opened this issue Feb 1, 2018 · 2 comments
Closed

Option to ignore/exclude by class name #64

vorburger opened this issue Feb 1, 2018 · 2 comments

Comments

@vorburger
Copy link
Contributor

It would be useful to be able to ignore/exclude by class name reg exp, e.g. for some cases of #28.

This is not possible today; the exclusionPatterns actually do not match on class name, but on tokens (I just debug it...), and the ignorePackages only on package names.

I'll see if I can come up with a PR for an ignoreClassPatterns kind of thing.
@vorburger vorburger mentioned this issue Feb 1, 2018
Closed
vorburger added a commit to vorburger/modernizer-maven-plugin that referenced this issue Feb 1, 2018
@vorburger
clarify exclusionPatterns in README
63563b6 
see also gaul#64
@vorburger vorburger mentioned this issue Feb 1, 2018
Closed
vorburger added a commit to vorburger/modernizer-maven-plugin that referenced this issue Feb 2, 2018
@vorburger
gaul#64 new option to ignore by class FQN regexp
2b6cd79 
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
vorburger added a commit to vorburger/modernizer-maven-plugin that referenced this issue Feb 2, 2018
@vorburger
gaul#64 new option to ignore by class FQN regexp
7c63cfe 
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
This was referenced Feb 2, 2018
Merged
Closed
@gaul
Copy link
Owner

gaul commented Feb 13, 2018

This makes sense although I share your confusion now that there are so many ways to exclude code.

vorburger added a commit to vorburger/modernizer-maven-plugin that referenced this issue Feb 13, 2018
@vorburger
gaul#64 new option to ignore by class FQN regexp
6d325ee 
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
vorburger added a commit to vorburger/modernizer-maven-plugin that referenced this issue Feb 13, 2018
@vorburger
gaul#64 new option to ignore by class FQN regexp
cbde41c 
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
vorburger added a commit to vorburger/modernizer-maven-plugin that referenced this issue Feb 13, 2018
@vorburger
gaul#64 new option to ignore by class FQN regexp
53424b0 
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
gaul pushed a commit that referenced this issue Feb 13, 2018
@vorburger @gaul
#64 new option to ignore by class FQN regexp
42eec28 
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
@vorburger
Copy link
Contributor Author

closing this, now that #67 is merged; thanks again @gaul !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vorburger @gaul