Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for different output formats and add codeclimate as an output format #235

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Add support for different output formats and add codeclimate as an output format #235

merged 3 commits into from
Feb 12, 2024

Conversation

themadprofessor
Copy link
Contributor

The source and target for the parent pom was changed to 1.7 due to:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.12.1:compile (default-compile) on project modernizer-maven-plugin: Compilation failure: Compilation failure: 
[ERROR] Source option 6 is no longer supported. Use 7 or later.
[ERROR] Target option 6 is no longer supported. Use 7 or later.

gaul
gaul requested changes Feb 7, 2024
View reviewed changes
Copy link
Owner

@gaul gaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great feature addition! Let's either use Java 7 try-with-resources or use the older gson to preserve Java 6 compatibility.

...-maven-plugin/src/main/java/org/gaul/modernizer_maven_plugin/output/CodeClimateOutputer.java Outdated
}
TypeToken<List<Entry>> type = new TypeToken<List<Entry>>() {
};
OutputStreamWriter writer = new OutputStreamWriter(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in try-with-resources since you bumped the Java version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That it should.

pom.xml Show resolved Hide resolved
@gaul
Copy link
Owner

gaul commented Feb 7, 2024

Could you add some blurb to the README advertising this feature?

gaul
gaul requested changes Feb 9, 2024
View reviewed changes
Copy link
Owner

@gaul gaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please fix typo before merging.

README.md Outdated Show resolved Hide resolved
@gaul gaul merged commit 641fed6 into gaul:master Feb 12, 2024
1 check passed
@gaul
Copy link
Owner

gaul commented Feb 12, 2024

Thank you for your contribution @themadprofessor! I pushed 2.8.0-SNAPSHOT.

@gaul gaul mentioned this pull request Feb 12, 2024
Open
@gaul
Copy link
Owner

gaul commented Feb 25, 2024

Deployed 2.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaul gaul gaul requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@themadprofessor @gaul