Protect FdEntity::physical_fd with fdent_lock

Found via ThreadSanitizer.
gaul · Jun 24, 2023 · 260af6c · 260af6c
1 parent 71ee9d4
commit 260af6c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/fdcache_entity.cpp b/src/fdcache_entity.cpp
@@ -2491,10 +2491,11 @@ bool FdEntity::PunchHole(off_t start, size_t size)
 {
     S3FS_PRN_DBG("[path=%s][physical_fd=%d][offset=%lld][size=%zu]", path.c_str(), physical_fd, static_cast<long long int>(start), size);
 
+    AutoLock auto_lock(&fdent_data_lock);
+
     if(-1 == physical_fd){
         return false;
     }
-    AutoLock auto_lock(&fdent_data_lock);
 
     // get page list that have no data
     fdpage_list_t   nodata_pages;
@@ -2532,10 +2533,19 @@ bool FdEntity::PunchHole(off_t start, size_t size)
 //
 void FdEntity::MarkDirtyNewFile()
 {
+    AutoLock auto_lock(&fdent_data_lock);
+
     pagelist.Init(0, false, true);
     pending_status = CREATE_FILE_PENDING;
 }
 
+bool FdEntity::IsDirtyNewFile() const
+{
+    AutoLock auto_lock(&fdent_data_lock);
+
+    return (CREATE_FILE_PENDING == pending_status);
+}
+
 bool FdEntity::AddUntreated(off_t start, off_t size)
 {
     bool result = untreated_list.AddPart(start, size);

diff --git a/src/fdcache_entity.h b/src/fdcache_entity.h
@@ -149,7 +149,7 @@ class FdEntity
         bool PunchHole(off_t start = 0, size_t size = 0);
 
         void MarkDirtyNewFile();
-        bool IsDirtyNewFile() { return (CREATE_FILE_PENDING == pending_status); }
+        bool IsDirtyNewFile() const;
 
         bool GetLastUpdateUntreatedPart(off_t& start, off_t& size) const;
         bool ReplaceLastUpdateUntreatedPart(off_t front_start, off_t front_size, off_t behind_start, off_t behind_size);