Address cppcheck 2.10 warnings

References s3fs-fuse#2162.
gaul · May 14, 2023 · 7ff94fa · 7ff94fa
1 parent 7bf4ca1
commit 7ff94fa
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/Makefile.am b/Makefile.am
@@ -44,6 +44,7 @@ cppcheck:
             --enable=warning,style,information,missingInclude \
             --suppress=missingIncludeSystem \
             --suppress=unmatchedSuppression \
+            --suppress=useStlAlgorithm \
             src/ test/
 
 #

diff --git a/src/addhead.cpp b/src/addhead.cpp
@@ -151,9 +151,7 @@ bool AdditionalHeader::Load(const char* file)
         addheadlist.push_back(paddhead);
 
         // set flag
-        if(!is_enable){
-            is_enable = true;
-        }
+        is_enable = true;
     }
     return true;
 }

diff --git a/src/fdcache.cpp b/src/fdcache.cpp
@@ -320,7 +320,7 @@ bool FdManager::HaveLseekHole()
         }
         FdManager::checked_lseek   = true;
         FdManager::have_lseek_hole = false;
-        return FdManager::have_lseek_hole;
+        return false;
     }
 
     // check SEEK_DATA/SEEK_HOLE options

diff --git a/src/fdcache_page.cpp b/src/fdcache_page.cpp
@@ -959,6 +959,7 @@ bool PageList::Serialize(CacheFileStat& file, bool is_output, ino_t inode)
                 is_modified = (1 == cvt_strtoofft(part.c_str(), /* base= */10) ? true : false);
             }
             // add new area
+            // cppcheck-suppress knownConditionTrueFalse
             PageList::page_status pstatus = 
               ( is_loaded && is_modified  ? PageList::PAGE_LOAD_MODIFIED : 
                 !is_loaded && is_modified ? PageList::PAGE_MODIFIED      :