Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defaults handling, perform linting #153

Closed
wants to merge 7 commits into from

Conversation

sammcj
Copy link

@sammcj sammcj commented Sep 19, 2022

This PR is for two things:

  1. Currently when trying to use this Action linting/actionlint fails because all optional inputs are marked as required: true.

Screen Shot 2022-09-20 at 9 05 52 am

I have refactored the bash parameters to set the defaults if no input is provided, and set the inputs to optional.

  1. Fixed numerous markdown formatting errors.

cc/ @gaurav-nelson

README.md Outdated Show resolved Hide resolved
Co-authored-by: Gaurav Nelson <gaurav.nelson@outlook.com>
@sammcj
Copy link
Author

sammcj commented Sep 20, 2022

The two markdown link errors are both false positives @gaurav-nelson

Screen Shot 2022-09-21 at 7 52 32 am

@sammcj
Copy link
Author

sammcj commented Sep 26, 2022

@gaurav-nelson do you know what's up with those false positive link checks?

@gaurav-nelson
Copy link
Owner

For GitHub can you see #136 (comment) and add it to the mlc-config file ?

The other one is probably disallowing agents. maybe add it to ignore list as well.

@sammcj
Copy link
Author

sammcj commented Sep 26, 2022

@gaurav-nelson thanks, done :)

mlc_config.json Outdated Show resolved Hide resolved
@gaurav-nelson
Copy link
Owner

@sammcj Can you please check the script again, I think the failed workflow is not running with the --config option. I am not sure though.

Also, See https://github.com/gaurav-nelson/github-action-markdown-link-check/actions/runs/3140346552/jobs/5101650177#step:3:154 which outputs the command we are running however the failed check doesn't list the command https://github.com/gaurav-nelson/github-action-markdown-link-check/actions/runs/3140346552/jobs/5101650203? 🤔

@sammcj
Copy link
Author

sammcj commented Sep 28, 2022

@gaurav-nelson Oh I see what's going on, it's relying on on all inputs being provided in order to have each parameter in the right place.

OK I'll refactor!

@sammcj sammcj marked this pull request as draft September 28, 2022 05:57
@sammcj sammcj marked this pull request as ready for review September 28, 2022 05:57
@sammcj sammcj closed this Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants