Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tortoise311 fork? #141

Open
fhunleth opened this issue Nov 11, 2021 · 5 comments
Open

tortoise311 fork? #141

fhunleth opened this issue Nov 11, 2021 · 5 comments

Comments

@fhunleth
Copy link
Contributor

fhunleth commented Nov 11, 2021

Hi @gausby,

I know that you moved on to other projects, and I want to be respectful to all of the good work that you've done with tortoise. How would you feel about the following proposal?

  1. I fork tortoise to tortoise311. I'm open to other names, but the idea is that tortoise311 makes no attempts to support MQTT 5.
  2. I merge outstanding PRs and make a release to hex.pm.
  3. I find a github organization to put this under. One option is to pull it under smartrent since we use Tortoise in production, but perhaps it's worth a tortoise-mqtt org since I know other companies that use Tortoise in production that might be willing to maintain.
  4. I find co-maintainers for tortoise311.
  5. I make an announcement about the tortoise311 fork and run the text of the announcement by you.
  6. We put a note in the README.md here to point to the tortoise311 fork. Perhaps this would make it easier for you to merge the MQTT 5 branch or publish it in an alpha or beta way with worrying about breaking production use?

The main point here is that I think that MQTT 3.1.1 support is sufficient for a lot of our use cases. I'm not sure where you stand with MQTT 5. I'd love to use some of its features, but I don't want it to complicate MQTT 3.1.1 fixes.

Of course, if you had other plans for Tortoise and haven't shared them yet, please let me know. I just want to find a way that we can keep this project going even if it's just bug fixes.

Thanks!

@brianmay
Copy link

@fhunleth Also see #130 (comment) if you haven't already.

@fhunleth
Copy link
Contributor Author

@brianmay I saw that, but I wasn't sure how that affects whether I fork tortoise or not? It sounds like you're unaffected since you're not using tortoise?

@brianmay
Copy link

No problem. Just making sure you didn't miss something potentially important.

@fhunleth
Copy link
Contributor Author

Cool. Yeah, I'll look through all of the issues and see what we can do.

@fhunleth
Copy link
Contributor Author

fhunleth commented Nov 18, 2021

We made the fork. It can be found at https://github.com/smartrent/tortoise311/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants