Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with undefined variables #20

Merged
merged 3 commits into from
Feb 13, 2021

Conversation

djensen47
Copy link
Contributor

I ran into a couple of bugs recently:

  • imageIndex was -1 and element was undefined so the call to substring failed
  • I kept getting undefined output in my md files

This PR puts up some guards to prevent that.

Fix issues with bad indexes and undefined variables
When there are many requests to download images, several tend to fail due to the parallel processing of the requests. This switches the processing to sequential.
@gautamdhameja gautamdhameja merged commit 8b82598 into gautamdhameja:master Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants