Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on the impact of a "Dummy commit" #1

Closed
jackdomleo7 opened this issue Oct 14, 2021 · 8 comments
Closed

Documentation on the impact of a "Dummy commit" #1

jackdomleo7 opened this issue Oct 14, 2021 · 8 comments

Comments

@jackdomleo7
Copy link

Hi, this could be what a lot of people are looking for!

I think it would be really beneficial to add some documentation on the pros and cons of the dummy commit. There may not be any cons but always good to reassure your users. 馃槉

@gautamkrishnar
Copy link
Owner

gautamkrishnar commented Oct 14, 2021

There is no cons for doing dummy commits. It won't change any file it just creates an empty git entry.

@gautamkrishnar
Copy link
Owner

On the plus side this dummy commit will keep your cron based triggers running. I hope that instructions on the readme is enough for most people to find this project. Feel free to improve the documentation if you have any ideas. @jackdomleo7

@jackdomleo7
Copy link
Author

Maybe it was just me getting confused. I think the documentation is fine for now. I'll close the issue. Thanks for the response!

@liskin
Copy link

liskin commented Feb 15, 2024

There is no cons for doing dummy commits. It won't change any file it just creates an empty git entry.

Which creates noise in git history and makes the project seem more active than it truly is. Not exactly "no cons", IMO.

I mean, most people probably don't care, but if anyone does, there is an alternative that doesn't use dummy commits: https://github.com/liskin/gh-workflow-keepalive

@gautamkrishnar
Copy link
Owner

gautamkrishnar commented Feb 15, 2024

@liskin 馃憤馃徎 thanks, that also looks like a good approach. When I wrote this action, there was no such API. Btw have you tested it in the long term (60 days)? Is it keeping the workflow alive?

@liskin
Copy link

liskin commented Feb 15, 2024

Yeah, I've been using that snippet for over 2 years now - xmonad/X11@a416159

@gautamkrishnar
Copy link
Owner

gautamkrishnar commented Feb 15, 2024

Thanks for confirming @liskin, this is a good approach. I will also make it a part of this workflow and provide APIs to opt into this approach.

@gautamkrishnar
Copy link
Owner

Just released a new version with API Keeplaive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants