Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/make all text scrollable #61

Merged

Conversation

aaxu
Copy link
Contributor

@aaxu aaxu commented May 24, 2017

I adjusted the QuestionPage class so that now the question and answer each take about half the terminal. There was a problem before where if the question had too many lines, the user would not be able to view the answer when in Interactive mode. This implementation resolves this issue. In addition, the amount of space question and answer takes up also adjusts if the user resizes the terminal. I had to move several classes and variables defined in socli_interactive to the global environment in order to make it accessible to the other functions as well.

I also made regular search, tag search, and manual search look like how questions are displayed when you are in interactive mode. This allows the text to not be cut off mid word and also provides all the answers for that question, not just the top one.

Note: This change does not apply to Windows since that uses another set of logic. Will need to implement some new type of interface to display text for Windows in the future.

aaxu added 2 commits May 23, 2017 19:28
…x that resizes even if user resizes the window. Resolves bug where answer can't be seen if Question is too long.
@gautamkrishnar
Copy link
Owner

Thanks a lot @aaxu. I think @e-beach will be the best person to review this.

@aaxu
Copy link
Contributor Author

aaxu commented May 24, 2017

@gautamkrishnar Do you know why the checks seems to have failed? I can't seem to figure out the error. There are no merge conflicts and it's been working fine.

@gautamkrishnar
Copy link
Owner

@aaxu just ignore the tests. I will fix it soon...

@aaxu
Copy link
Contributor Author

aaxu commented May 24, 2017

Oh alright @gautamkrishnar. Thanks a lot!

@aaxu
Copy link
Contributor Author

aaxu commented May 24, 2017

What are people's thoughts on a pager module like less to display instead of the format seen in interactive mode? I think this format I implemented is more UI friendly, but less may be better for more advanced users because it provides functions and other shortcut keys. If we use a paging module, we would also have to make words somehow be printed better so that they don't break line midword to make it more readable.

@gautamkrishnar
Copy link
Owner

gautamkrishnar commented May 25, 2017

@aaxu yes i think using interactive mode is better... We can use pager for windows since it dont support interactive mode.

@gautamkrishnar
Copy link
Owner

@e-beach requesting your review...

@gautamkrishnar gautamkrishnar merged commit 1ea38a9 into gautamkrishnar:develop Jun 3, 2017
@aaxu aaxu deleted the feature/MakeAllTextScrollable branch June 5, 2017 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants