Use Loopback IP address auth flow instead of deprecated OOB #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html https://developers.google.com/identity/protocols/oauth2/resources/oob-migration Closes gauteh#215 Co-authored-by: Toke Høiland-Jørgensen <toke@toke.dk>
|
Great! @tohojo do you wish to be |
|
I'm okay with co-authored-by; thanks for turning this into a proper PR! :) |
|
Thanks, merged. Maybe instructions need to be updated as well? Does this close the auth issue? |
I believe it does, or at least everything is now working on my end. I took a look at the README and everything there looks good to me from a cursory look. |
|
Great!
lør. 31. des. 2022, 15:36 skrev Stefan Kangas ***@***.***>:
… Thanks, merged. Maybe instructions need to be updated as well? Does this
close the auth issue?
I believe it does, or at least everything is now working on my end. I took
a look at the README and everything there looks good to me from a cursory
look.
—
Reply to this email directly, view it on GitHub
<#231 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAN36377VYE3OWHIEERQ5LWQBAFBANCNFSM6AAAAAATNRA7MY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the authorization flow, as discussed in #215. @tohojo already did all the heavy lifting and wrote up a patch, so I just tested that it works and made this pull request.
I would have actually preferred to put the commit in Toke's name, but I didn't want to do so without his consent. Instead, I acknowledge him in a
Co-authored-bytag in the commit message. If Toke prefers, I'm obviously happy to make him the author instead. (My own changes were minimal.)The patch works here, but more testing is obviously welcome.
For reference, see:
https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html
https://developers.google.com/identity/protocols/oauth2/resources/oob-migration