Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github action for black formatter and running black on the repo #247

Merged
merged 3 commits into from
Sep 10, 2023

Conversation

digitalsignalperson
Copy link
Contributor

@digitalsignalperson digitalsignalperson commented Jun 1, 2023

black.yml is setup per the official instructions here https://black.readthedocs.io/en/stable/integrations/github_actions.html

I tested these 3 commits here digitalsignalperson#1 to see the action fail initially, then pass after running black . on the repo

black .
reformatted /home/andy1/git/lieer/lieer/__init__.py
reformatted /home/andy1/git/lieer/tests/__init__.py
reformatted /home/andy1/git/lieer/tests/test_local.py
reformatted /home/andy1/git/lieer/setup.py
reformatted /home/andy1/git/lieer/lieer/nobar.py
reformatted /home/andy1/git/lieer/lieer/resume.py
reformatted /home/andy1/git/lieer/lieer/local.py
reformatted /home/andy1/git/lieer/lieer/remote.py
reformatted /home/andy1/git/lieer/lieer/gmailieer.py

All done! ✨ 🍰 ✨

@digitalsignalperson
Copy link
Contributor Author

Hmm, maybe it would help to split into 2 PRs, one just for the github action, and then one just for pushing the formatting changes from running black

@gauteh
Copy link
Owner

gauteh commented Jun 2, 2023

Thanks. I don't think I can merge this before #242 goes in, otherwise that PR is going to be completely messed up. It should be easy to update this PR later by keeping the first two commits and redoing the auto-formatting.

@gauteh gauteh merged commit 4d26ce0 into gauteh:master Sep 10, 2023
4 checks passed
@gauteh
Copy link
Owner

gauteh commented Sep 10, 2023

Thanks, finally merged.

@gauteh gauteh temporarily deployed to github-pages September 10, 2023 06:51 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants