Fixed concurrency errors in MemoryCache when using dotnetcore #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed concurrency errors in MemoryCache (#101)
When using dotnetcore, adding a cache entry lead to InvalidOperationExceptions
if a new registration callback was added concurrently.
The issue was caused by re-using a single MemoryCacheEntryOptions for multiple
cache entries. This change resolves the issue by creating a new options
instance for each cache entry.
This causes a change of behavior with the eviction callbacks.
Previously, when using dotnetcore, all registered callbacks would be kept and
invoked on a cache eviction.
Now, only the last registered callback will be invoked. This behavior is
consistent with the implementation for .NET Framework 4.5.2.
The default implementation of CacheRepository will register a new callback in
the constructor of each instance.
Because each callback modifies a static class field, it should not matter
which callback is invoked.
It might, however, affect custom implementations.