Skip to content
This repository has been archived by the owner on Mar 2, 2022. It is now read-only.

Multiple code_url and externs_url #2

Closed
probins opened this issue Aug 13, 2014 · 3 comments
Closed

Multiple code_url and externs_url #2

probins opened this issue Aug 13, 2014 · 3 comments

Comments

@probins
Copy link

probins commented Aug 13, 2014

The options passed to the compiler is a JS object, meaning that a property can only occur once. code_url and externs_url can however occur multiple times. Perhaps define these as an array, and have the plugin convert those into multiple params?

And of course if code_url(s) is defined, there won't be js_code. :-)

gavinhungry added a commit that referenced this issue Aug 22, 2014
@gavinhungry
Copy link
Owner

@probins, try it out now! Pass null as the first argument to compile if you don't need to specifiy js_code.

@probins
Copy link
Author

probins commented Aug 24, 2014

yeah, that seems to work nicely thanks.

Perhaps update the readme too?

@gavinhungry gavinhungry reopened this Aug 26, 2014
@gavinhungry
Copy link
Owner

@probins,

Turns out this won't work. I'm encoding everything as part of the URL, and with a longish file, it will now fail. Looking into this again.

gavinhungry added a commit that referenced this issue Aug 26, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants