Skip to content

Commit

Permalink
implemented work around for chrome and opera bug with css variable
Browse files Browse the repository at this point in the history
  • Loading branch information
gavinmcfarland committed Oct 17, 2019
1 parent e0c5f4b commit de2e496
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@
--guess07: calc((var(--guess06) + ( var(--number) / var(--guess06))) / 2);
--guess08: calc((var(--guess07) + ( var(--number) / var(--guess07))) / 2);
--guess09: calc((var(--guess08) + ( var(--number) / var(--guess08))) / 2);
--guess10: calc((var(--guess09) + ( var(--number) / var(--guess09))) / 2);
width: calc(50% - (var(--guess10) * 1px));
width: calc(50% - (calc((var(--guess09) + ( var(--number) / var(--guess09))) / 2) * 1px));
}
```

Expand Down
5 changes: 2 additions & 3 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default postcss.plugin('postcss-sqrt', () => {

// Replace the function with css variable that calculates square root
let newValue = decl.value.replace(SQRT_REGEX, function () {
return 'var(--guess10)'
return `calc((var(--guess09) + ( ${functionValue} / var(--guess09))) / 2)`
})

// Update the declaration value
Expand All @@ -41,8 +41,7 @@ export default postcss.plugin('postcss-sqrt', () => {
--guess06: calc((var(--guess05) + ( ${functionValue} / var(--guess05))) / 2);
--guess07: calc((var(--guess06) + ( ${functionValue} / var(--guess06))) / 2);
--guess08: calc((var(--guess07) + ( ${functionValue} / var(--guess07))) / 2);
--guess09: calc((var(--guess08) + ( ${functionValue} / var(--guess08))) / 2);
--guess10: calc((var(--guess09) + ( ${functionValue} / var(--guess09))) / 2);`
--guess09: calc((var(--guess08) + ( ${functionValue} / var(--guess08))) / 2);`

let props = postcss.parse(TEMPLATE)

Expand Down
3 changes: 1 addition & 2 deletions test/basic.expect.css
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,5 @@
--guess07: calc((var(--guess06) + ( var(--number) / var(--guess06))) / 2);
--guess08: calc((var(--guess07) + ( var(--number) / var(--guess07))) / 2);
--guess09: calc((var(--guess08) + ( var(--number) / var(--guess08))) / 2);
--guess10: calc((var(--guess09) + ( var(--number) / var(--guess09))) / 2);
width: calc(50% - (var(--guess10) * 1px));
width: calc(50% - (calc((var(--guess09) + ( var(--number) / var(--guess09))) / 2) * 1px));
}

0 comments on commit de2e496

Please sign in to comment.