Bugfix #3 Fix rate limit error #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I'll test it out. |
gavinr
requested changes
Aug 3, 2022
import.js
Outdated
| } | ||
|
|
||
| // if we have an assignee column, pass that. | ||
| if (assigneeIndex > -1 && row[assigneeIndex] !== "") { | ||
| sendObj.assignees = row[assigneeIndex].replace(/ /g, "").split(","); | ||
| sendObj.issue.assignee = row[assigneeIndex].replace(/ /g, "").split(","); |
There was a problem hiding this comment.
This does not work. Try importing https://github.com/gavinr/github-csv-tools/blob/master/test/4.csv (change the username in the csv to your username). I get error:
message: 'Invalid request.\n' +
'\n' +
`For 'properties/assignee', ["MyUserName"] is not a string or null.`,
There was a problem hiding this comment.
I fixed the assignee problem and I test with all tests files.
All are OK (noTitle.csv return "Title required by GitHub, but not found in CSV.")
|
merged in #82. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use endpoint "/import/issues" to avoid rate limit errors
Related to issue #3