Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: button #11

Open
rayman89 opened this issue May 30, 2018 · 6 comments
Open

Request: button #11

rayman89 opened this issue May 30, 2018 · 6 comments

Comments

@rayman89
Copy link

Could you add a button that does the addon functionality? I tend to forget I have the addon otherwise.

@rayman89
Copy link
Author

are you still working on the addon @gavinsharp

@simonlindholm
Copy link
Collaborator

@gavinsharp isn't, but I am, from time to time. (Sorry, I got a notification about this issue, then completely forgot about it.) This seems like a good idea, though it requires me spending some free time to code it, and also to design a button. Also, I wonder whether WebExtensions supports having a button being invisible by default.

@simonlindholm
Copy link
Collaborator

(oh, it does! "default_area": "menupanel")

@rayman89
Copy link
Author

rayman89 commented Jul 10, 2018

Thank you for your response. The button icon can be anything for example https://www.shutterstock.com/image-vector/gif-animation-button-icon-452957236 with red cross or prohibit sign over it https://www.shutterstock.com/image-vector/prohibition-sign-template-326440301?src=0Bu0j6W03qlt4H3j_m2QRg-1-6 . Also there is no need to make it invisible IMO. The users that do not want the button can remove it right clicking on the toolbar and selecting customize.

EDIT: great even better then

@simonlindholm
Copy link
Collaborator

Yep, it's definitely one of the simplest things to find an icon for, but you'd still have to muck about with licenses and sizes and make it look good in the Firefox UI.

If you want to you could definitely try adding the button yourself, it should be pretty simple. Just add a browser_action to manifest.json, and a browserAction listener that does sendMessageToActiveTab({type: "do-super-stop"});. According to this article it should be simple to test it via about:debugging.

@rayman89
Copy link
Author

I would love to do that but I'm not a dev sadly. I'll be looking forward for the update when you are able to do it. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants