Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button alternative to shift+esc #14

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Conversation

hoffr
Copy link
Contributor

@hoffr hoffr commented Sep 23, 2020

icons made by me in paint.NET, hope you like em. never touched javascript, web or extension code up until this point but i think it does what @simonlindholm on #11 suggested

@simonlindholm
Copy link
Collaborator

Ooh, lovely! Question is whether we want the button to be visible by default, but I guess it might be fine to make it so for discoverability's sake?

If you have a higher-res (48x48 or 96x96) version of that icon it would be nice to use the same icon for the extension itself: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/icons I'm guessing you hand-drew it in 32x32 making that hard, though.

@hoffr
Copy link
Contributor Author

hoffr commented Sep 23, 2020

I personally think many users would expect it to be visible by default, but it can easily be hidden via customize like with any other extension

Included in the latest commit is a paint.NET project file (.pdn) in case any edits are desired

@simonlindholm
Copy link
Collaborator

Yeah, I suppose, let's go with this. Thanks for the high-res icon and paint.NET project! I'll go ahead and merge this and publish a new release.

@simonlindholm simonlindholm merged commit 5e05cc8 into gavinsharp:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants