Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sporadic crashes with NoFall enabled #59

Closed
raydeejay opened this issue Mar 25, 2023 · 2 comments
Closed

Sporadic crashes with NoFall enabled #59

raydeejay opened this issue Mar 25, 2023 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers reproduced v-1.19.4

Comments

@raydeejay
Copy link

Describe the bug
From time to time, the game will crash trying to access an implementation of com.peasenet.mixinterface.IClientPlayerEntity.getVelocity()

To Reproduce
Enable NoFall. I've triggered this bug twice, once by flying around with Fly and NoFall and accidentally disabling fly and falling on something. The second time was flying with elytra, only NoFall enabled, to the top of an obsidian pillar in the end.

Expected behavior
The game doesn't crash :-)

Version Info (please complete the following information):
1.4.1-hotfix1+1.19.4
crash-2023-03-25_18.32.56-client.txt

@raydeejay raydeejay added the bug Something isn't working label Mar 25, 2023
@GT3CH1
Copy link
Member

GT3CH1 commented Mar 25, 2023

Yikes, that's an uh-oh on my behalf. I'll work on this.

GT3CH1 added a commit that referenced this issue Apr 1, 2023
@GT3CH1 GT3CH1 linked a pull request Apr 1, 2023 that will close this issue
2 tasks
@GT3CH1 GT3CH1 mentioned this issue Apr 1, 2023
2 tasks
GT3CH1 added a commit that referenced this issue Apr 1, 2023
@GT3CH1 GT3CH1 mentioned this issue Apr 1, 2023
2 tasks
GT3CH1 added a commit that referenced this issue Apr 1, 2023
@GT3CH1 GT3CH1 closed this as completed in d4263aa Apr 1, 2023
@GT3CH1
Copy link
Member

GT3CH1 commented Apr 1, 2023

I was finally able to get to this today - I have patched and merged this into the mainline branch, with a release available as 1.4.2. As always, please let me know if you find something else funky in the mod. Thanks again!

GT3CH1 added a commit that referenced this issue Apr 16, 2023
* Move kotlin classess to kotlin directory, move mixins to java directory & restored them back to java.

* Fix fly not behaving as expected

* Finish fullbright bug

* Fix missing implements for IClientPlayerEntity, add setting for FreeCam speed

* Switch Settings back to Java

* Make Waypoints work per-dimension

* Move waypoint settings to own category, add fix to put waypoints back into render in main menu

* Move waypoint settings to own category, add fix to put waypoints back into render in main menu

* Fix ESP's not showing when WorldRenderer.drawBox is overridden by other mods

* Change way to render esp's using planes instead.

* Waypoint Modifications (#56)

* Switch Settings back to Java

* Make Waypoints work per-dimension

* Move waypoint settings to own category, add fix to put waypoints back into render in main menu

* Move waypoint settings to own category, add fix to put waypoints back into render in main menu

* Fix ESP's not showing when WorldRenderer.drawBox is overridden by other mods

* Change way to render esp's using planes instead.

* Add dimension array to Waypoints to allow for user-configurable dimensions on the fly.

Made Tracers render at the same time as ESPs

* Cleanup waypoint classes

* Fix #59  - getVelocity not implemented

* Add better mob selection for tracer/esp's (#62)

* Add new UI page for rendering mob esp

* Add new UI page for rendering mob tracer

* Add java settings back?!

* Update doc comments

* Update gavui version

* Patch AntiHurt for issue #65

Signed-off-by: GT3CH1 <gavinpease@gmail.com>

* Esp/Tracer config do not need nullable extensions

* Use constant colors in ModHealthTag

* Rework GuiEsp+GuiTracer

* Make some properties in GuiWaypoint not nullable.

* Make some properties in GuiXray not nullable.

* Make configurations, event manager instance, etc. not-nullable in GavinsMod.kt

* Add ability to enable/disable viewbobbing with tracer mods.

Extracted common code for tracer mods into ModTracer.kt, fix view bob issue as described in #65

* Add translation for tracer view bob cancel

* Bump mod version to 1.4.3

---------

Signed-off-by: GT3CH1 <gavinpease@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers reproduced v-1.19.4
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants