Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclusion doesn't work on a path when directory starts with a dot symbol #32

Closed
qrwex opened this issue Dec 20, 2017 · 3 comments
Closed
Assignees
Labels

Comments

@qrwex
Copy link

qrwex commented Dec 20, 2017

The problem is in a /src/watcher.js:16

The following code result is false:
console.log(mm('users/example/directory/node_modules/.micromatch.DELETE/node_modules', ['**/example/directory/**']).length > 0);

Possible solution:
if (exclude && mm([localPath], exclude, {dot: true}).length > 0) {

@gavoja gavoja added the bug label Feb 27, 2018
gavoja added a commit that referenced this issue Feb 27, 2018
@gavoja
Copy link
Owner

gavoja commented Feb 27, 2018

Should work with 3.0.0. Reopen otherwise.

@gavoja gavoja closed this as completed Feb 27, 2018
@erperejildo
Copy link

erperejildo commented May 2, 2018

@gavoja running latest version still getting this issue:
screen shot 2018-05-02 at 13 53 52
screen shot 2018-05-02 at 13 54 42

Downgraded to 1.1.1 and working again

@abmaonline
Copy link
Contributor

The parameters for the micromatch call are not in the right order, fixed it in #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants