Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update (and fix) Iris examples for HTTP/2. #32

Closed
wants to merge 2 commits into from
Closed

Update (and fix) Iris examples for HTTP/2. #32

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 2, 2017

No description provided.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 97.162% when pulling 15c98f9 on iris-contrib:master into dc92986 on gavv:master.

@gavv
Copy link
Owner

gavv commented Jan 5, 2017

Hi, sorry for delay.

A few questions about the PR:

  • Did iris drop fasthttp support?
  • Why did you remove stream/chunked example?
  • Why did you change GET to POST for /params/:x/:y?

@gavv gavv added this to the v1 milestone Jan 5, 2017
@ghost
Copy link
Author

ghost commented Jan 5, 2017

  • Iris v6 yes, Iris v5 no, it lives in its own branch and all docs and examples too (its users still have support and real-time assistance by me).
  • Because at that time we had no stream function and I maybe forgot to code that too, I will do this inside the afternoon and I'll re-add it, it's easy
  • Because on other .go files you have them in POST (for FormValue) and I though it will be good to align with others for readability

@gavv
Copy link
Owner

gavv commented Jan 5, 2017

Great, waiting for the streaming example back.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 97.162% when pulling 9b30100 on iris-contrib:master into dc92986 on gavv:master.

@ghost
Copy link
Author

ghost commented Jan 7, 2017

Done, thanks for your time!

gavv added a commit that referenced this pull request Jan 8, 2017
@gavv
Copy link
Owner

gavv commented Jan 8, 2017

Thanks! Merged.

Since the iris example was the only example that demonstrated FastBinder usage and it doesn't do it any more, I've also added a standalone fasthttp example.

@gavv gavv closed this Jan 8, 2017
@ghost
Copy link
Author

ghost commented Jan 8, 2017

Or you could/can copy the old _examples/iris_test.go/iris.go, rename them to iris_fasthttp_test.go/iris_fasthttp.go and just change the import path to: gopkg.in/kataras/iris.v5 (in order to demonstrate more tests). I though to do it too but you didn't asked :/ Two iris examples in the same folder will be a little strange, maybe you have right :) Good job and thanks for accepting the pr.

@gavv
Copy link
Owner

gavv commented Jan 8, 2017

I think there is no need to have two identical sets of examples (for iris5 and iris6) just to demonstrate that httpexpect can use fasthttp too. A minimal FastBinder usage example should be enough, since the rest API is the same for net/http and fasthttp handlers.

@ghost
Copy link
Author

ghost commented Jan 8, 2017

Yeap, that I though too :) Nice job mate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants