-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update (and fix) Iris examples for HTTP/2. #32
Conversation
Hi, sorry for delay. A few questions about the PR:
|
|
Great, waiting for the streaming example back. |
Done, thanks for your time! |
Thanks! Merged. Since the iris example was the only example that demonstrated FastBinder usage and it doesn't do it any more, I've also added a standalone fasthttp example. |
Or you could/can copy the old _examples/iris_test.go/iris.go, rename them to iris_fasthttp_test.go/iris_fasthttp.go and just change the import path to: gopkg.in/kataras/iris.v5 (in order to demonstrate more tests). I though to do it too but you didn't asked :/ Two iris examples in the same folder will be a little strange, maybe you have right :) Good job and thanks for accepting the pr. |
I think there is no need to have two identical sets of examples (for iris5 and iris6) just to demonstrate that httpexpect can use fasthttp too. A minimal FastBinder usage example should be enough, since the rest API is the same for net/http and fasthttp handlers. |
Yeap, that I though too :) Nice job mate |
No description provided.