Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix value table-driven test cases #325

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Fix value table-driven test cases #325

merged 1 commit into from
Mar 3, 2023

Conversation

gpjservais
Copy link
Contributor

@gpjservais gpjservais commented Mar 3, 2023 •
edited
Loading

Addresses #324 to replace map of structs with a slice of structs and rename "instance" to "tc."

This is to fix updates made while refactoring tests as part of #284 to use table-driven style.

This is ready for review.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 95.291%. Remained the same when pulling 0536a3c on gpjservais:fix-map-usage-and-naming-conventions into b733ce6 on gavv:master.

@gavv gavv merged commit cabfe7c into gavv:master Mar 3, 2023
@gavv
Copy link
Owner

gavv commented Mar 3, 2023

Thanks!!

@gpjservais gpjservais deleted the fix-map-usage-and-naming-conventions branch March 3, 2023 17:51
Rohith-Raju pushed a commit to Rohith-Raju/httpexpect that referenced this pull request Mar 4, 2023
@gpjservais @Rohith-Raju
Fix value table-driven test cases (gavv#325)
526be0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gpjservais @coveralls @gavv