Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved bodyWrapper GetBody test issue #390

Closed
wants to merge 2 commits into from
Closed

Improved bodyWrapper GetBody test issue #390

wants to merge 2 commits into from

Conversation

tymnec
Copy link
Contributor

@tymnec tymnec commented Apr 8, 2023

Closes #378

📑 Description

Improved by adding few more cases. (Done!)

✅ Checks

  • start reading body, then call GetBody
  • read body until EOF (using io.ReadAll), then call GetBody
  • read body until EOF (using io.ReadAll), then call Close, then call GetBody
  • In addition, add three more subtests like the previous three, but with Rewind before GetBody call.
  • My pull request adheres to the code style of this project
  • If my code requires changes to the documentation I have updated the documentation as required.
  • All the tests have passed

@tymnec tymnec closed this Apr 8, 2023
@tymnec tymnec changed the title Improved bodyWrapper GetBody test issue #378 Improved bodyWrapper GetBody test issue Apr 8, 2023
@tymnec tymnec reopened this Apr 8, 2023
@gavv
Copy link
Owner

gavv commented Apr 8, 2023

Thanks for PR, will take a look in upcoming days.

Please fix linter and formatting issues reported by CI.

@gavv gavv added ready for review Pull request can be reviewed needs revision Pull request should be revised by its author labels Apr 8, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

☔ The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts.

@github-actions github-actions bot added the needs rebase Pull request has conflicts and should be rebased label Oct 2, 2023
@gavv
Copy link
Owner

gavv commented Oct 2, 2023

Hi, thanks for the patch!

I've resolved conflicts and formatting issues and merged it manually: 4ba32bd

Here is a follow-up commit with some additional cleanup and refinements: aeaad01

@gavv gavv closed this Oct 2, 2023
@gavv gavv removed needs revision Pull request should be revised by its author ready for review Pull request can be reviewed needs rebase Pull request has conflicts and should be rebased labels Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve bodyWrapper GetBody test
2 participants
@tymnec @gavv