Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding phantomjs-url-template option #16

Merged
merged 10 commits into from
May 7, 2014
Merged

Adding phantomjs-url-template option #16

merged 10 commits into from
May 7, 2014

Conversation

toumorokoshi
Copy link
Contributor

It would be nice to have an option phantomjs-url-template, that allows one to use a template instead of a url base (in case we have to upload to a repository system that doesn't provide the same file format as phantomjs does).

Here's the snippet from the readme:

phantomjs-url-template
    If phantomjs-url and phantomjs-url-template are
    not specified, you can set a template which will populate various
    variables. The variables should be wrapped in {}, and the
    following values are supported:

    * arch: the architecture. x86_64 or i686
    * phantom_platform: the platform, following the format dictated by the standard phantomjs url (e.g. linux, macosx)
    * phantom_extension: the extension, as specified by the format dictated by the standard phantomjs url (e.g. tar.bz2, zip)
    * platform: the platform, as specified by sys.platform (e.g. linux, darwin)
    * version: the version of phantomjs

    The default template is:

        https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-{version}-{phantom_platform}.{phantom_extension}

gawel added a commit that referenced this pull request May 7, 2014
Adding phantomjs-url-template option
@gawel gawel merged commit a099050 into gawel:master May 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants