Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an S3 log handler #19

Merged
merged 4 commits into from
Sep 9, 2014
Merged

Add an S3 log handler #19

merged 4 commits into from
Sep 9, 2014

Conversation

singingwolfboy
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.36%) when pulling 63363cf on singingwolfboy:logger-s3-handler into 226c2b3 on gawel:master.

@gawel
Copy link
Owner

gawel commented Aug 26, 2014

First thanks for your contributions.

Looks like moto is not py3 compatible. Does this require an incoming release ? Can you at least add a skipIf(PY3) for your test case ?

Also why are you using moto instead of boto ? I'm just curious

@singingwolfboy
Copy link
Contributor Author

moto is a testing tool for mocking out boto, so that you can test code that uses boto without needing an AWS account or an internet connection. I didn't realize it wasn't Python 3 compatible until I saw the test failures on Travis: I'm currently working on a pull request to make moto Python 3 compatible, but it's not there yet, and even when it is, I don't know when it will be merged and when there will be a new moto release. I'll add a skipIf(PY3), as you suggest.

And you're quite welcome! I just found this project a few days ago, and it looks like almost exactly what I need -- so I decided to build what was missing. Yay open source!

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling bb5a6d3 on singingwolfboy:logger-s3-handler into 226c2b3 on gawel:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6988b1a on singingwolfboy:logger-s3-handler into af3bd32 on gawel:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.36%) when pulling 2e83ca0 on singingwolfboy:logger-s3-handler into af3bd32 on gawel:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a508e03 on singingwolfboy:logger-s3-handler into af3bd32 on gawel:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.36%) when pulling 51f3597 on singingwolfboy:logger-s3-handler into af3bd32 on gawel:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.36%) when pulling eb5f6e1 on singingwolfboy:logger-s3-handler into 12e24d4 on gawel:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) when pulling 1736397 on singingwolfboy:logger-s3-handler into 12e24d4 on gawel:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) when pulling f5c43da on singingwolfboy:logger-s3-handler into 12e24d4 on gawel:master.

@singingwolfboy
Copy link
Contributor Author

Tests are finally passing! Hallelujah!

gawel added a commit that referenced this pull request Sep 9, 2014
@gawel gawel merged commit 9ae4f6d into gawel:master Sep 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants