session-16 arrays #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix typo
|
I know that I'm not a reviewer but I took a look at your workshop and nice job, by the way, but I noticed that you both are using a lot of big headings and maybe you can provide a better explanation for the array methods examples. This is just a suggestion from me and I hope you take it into consideration ✌️ |
MohammedYehia
requested changes
Mar 7, 2020
adding pop-push/ shift-unshift methods
hshahwan
reviewed
Mar 10, 2020
hshahwan
reviewed
Mar 10, 2020
hshahwan
reviewed
Mar 10, 2020
hshahwan
reviewed
Mar 10, 2020
hshahwan
reviewed
Mar 10, 2020
|
@Fatmasiam is this ready for review? |
|
@MohammedYehia Yes |
MohammedYehia
requested changes
Mar 15, 2020
There was a problem hiding this comment.
hey @Fatmasiam thanks for your work
just a few tweaks and we are done
|
|
||
| ``` | ||
| This form of syntax should only be used when you want the body of the loop to execute at least once regardless of the condition being truthy. Usually, the other form is preferred: while(…) {…}. | ||
| **Refreshing Question** :keycap_star: ==> separate[explain] the work for the previous example if the condition will `i <= alpha.length` |
There was a problem hiding this comment.
could this be something like this
Suggested change
| **Refreshing Question** :keycap_star: ==> separate[explain] the work for the previous example if the condition will `i <= alpha.length` | |
| **Refreshing Question** :keycap_star: what will happen if the condition was `i <= alpha.length` |
Co-Authored-By: Mohammed <MohammedYehia@users.noreply.github.com>
Co-Authored-By: Mohammed <MohammedYehia@users.noreply.github.com>
MohammedYehia
approved these changes
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readme.mdfile