Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBuilder no longer requires BlankSlate #60

Closed
phoet opened this issue Oct 18, 2012 · 3 comments
Closed

JBuilder no longer requires BlankSlate #60

phoet opened this issue Oct 18, 2012 · 3 comments

Comments

@phoet
Copy link
Contributor

phoet commented Oct 18, 2012

the latest version of JBuilder does not require BlankSlate anymore. If the gem is not present in the bundle otherwise, gon raises an error:

/Users/uschi/.rvm/gems/ruby-1.9.3-p194@global/gems/bundler-1.2.0.rc/lib/bundler/rubygems_integration.rb:147:in `block in replace_gem': blankslate is not part of the bundle. Add it to Gemfile. (Gem::LoadError)
    from /Users/uschi/.rvm/gems/ruby-1.9.3-p194@wlw/gems/gon-4.0.0/lib/gon.rb:2:in `<top (required)>'

what would be the best way to deal with this? just removing the require statement would probably break backwards compatibility.

@gazay
Copy link
Owner

gazay commented Oct 18, 2012

Do you mean with old versions of JBuilder? I think we just need to check version of jbuilder in blankslate requirement check. Can you provide patch?

Thank you for issue!

@phoet
Copy link
Contributor Author

phoet commented Oct 18, 2012

will have a look

phoet added a commit to phoet/gon that referenced this issue Oct 19, 2012
@gazay
Copy link
Owner

gazay commented Oct 26, 2012

It seems that we don't need to require BlankSlate anymore at all. I checked different versions with different rails envs, and I don't see exceptions like before. So I removed requirement of blankslate now, it will be in v4.0.1 soon.

Thank you for your help!

@gazay gazay closed this as completed Oct 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants