-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KrakenAdaptor place order with expected precision #131
Conversation
Fetch decimal price precision from kraken api use it for volume and price when placing orders. Fixes #126
Hi @maiph, thanks for the PR. Looks like a SpotBugs issue in the Travis build:
Happy to take a look if you've not got time. Hopefully we can get a release out later this week :-) |
I can take a look at it. |
Sure, a You can also run the spotbugs maven profile using Cheers. |
Hi @maiph , I'm planing a release this week, be great to get your fix in. I can sort out the SpotBugs issue if you need me to 👍 |
Hey @gazbert , I'll be busy the next few weeks so you can go ahead and wrap this up. Cherrs |
Merging this into master and will fix the SID issue highlighted by SpotBugs. |
Added a way for the Kraken adaptor to fetch the configuration from decimal values precision and place order accordingly.
Fixes #126