Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KrakenAdaptor place order with expected precision #131

Merged
merged 4 commits into from
Jan 26, 2021
Merged

KrakenAdaptor place order with expected precision #131

merged 4 commits into from
Jan 26, 2021

Conversation

maiph
Copy link
Contributor

@maiph maiph commented Jan 17, 2021

Added a way for the Kraken adaptor to fetch the configuration from decimal values precision and place order accordingly.

Fixes #126

Fetch decimal price precision from kraken api use it for volume and
  price when placing orders.

Fixes #126
@gazbert gazbert added the bug label Jan 17, 2021
@gazbert gazbert added this to In Progress in BX-bot Jan 17, 2021
@gazbert
Copy link
Owner

gazbert commented Jan 18, 2021

Hi @maiph, thanks for the PR. Looks like a SpotBugs issue in the Travis build:
https://travis-ci.com/github/gazbert/bxbot/builds/213546871

[ERROR] Low: com.gazbert.bxbot.exchanges.KrakenExchangeAdapter$KrakenAssetPairsConfig is Serializable; consider declaring a serialVersionUID [com.gazbert.bxbot.exchanges.KrakenExchangeAdapter$KrakenAssetPairsConfig] At KrakenExchangeAdapter.java:[lines 656-675] SE_NO_SERIALVERSIONID [INFO]

Happy to take a look if you've not got time.

Hopefully we can get a release out later this week :-)

@maiph
Copy link
Contributor Author

maiph commented Jan 19, 2021

I can take a look at it.
Is there any way to run SpotBugs locally to check for other errors that may exist?

@gazbert
Copy link
Owner

gazbert commented Jan 19, 2021

I can take a look at it.
Is there any way to run SpotBugs locally to check for other errors that may exist?

Sure, a ./mvnw clean install or ./gradlew build run locally should run SpotBugs as part of the build.

You can also run the spotbugs maven profile using ./mvnw clean install -P spotbugs

Cheers.

@gazbert
Copy link
Owner

gazbert commented Jan 24, 2021

Hi @maiph , I'm planing a release this week, be great to get your fix in. I can sort out the SpotBugs issue if you need me to 👍

@maiph
Copy link
Contributor Author

maiph commented Jan 26, 2021

Hey @gazbert , I'll be busy the next few weeks so you can go ahead and wrap this up.

Cherrs

@gazbert
Copy link
Owner

gazbert commented Jan 26, 2021

Merging this into master and will fix the SID issue highlighted by SpotBugs.

@gazbert gazbert merged commit 4b77d2a into gazbert:master Jan 26, 2021
@gazbert gazbert self-requested a review January 26, 2021 20:50
@gazbert gazbert moved this from In Progress to Done in BX-bot Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
2 participants