add cryptopia exchange adapter #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this Niko! 👍 |
|
Hi Niko, sorry for not getting back sooner - day job excuses - code looks good! We'll need to update the README to mention new adapter being supported + we'll need a new sample config folder too: ./config/samples/cryptopia/*.xml files... I'll review this properly over the weekend - bank holiday in UK! Is the adapter all up and running ok with you? I don't have a cryptopia account to spin the bot up against... Feel free to add your name to the MIT copyright in your new classes too 👍 All being well, I'll create a new release this weekend. G |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly a copy from bitfinex adapter
integration test done with my cryptopia account