Vendor gz_cmake2 unconditionally. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Ubuntu Noble, there is no usable upstream version of gz-cmake2 and we are in the process of updating all Gazebo packages to be directly vendorable. In the meantime, switch the current Gazebo vendor packages in ROS 2 core to vendor unconditionally.
clalancette
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Looks good to me; I'll run CI on it next.
Note that we'll have to do the same thing for https://github.com/gazebo-release/gz_math6_vendor .
CI:
- Linux
- Linux-aarch64
- Windows
Yep, I have the branch open already I'm just checking to see how this turn sout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ubuntu Noble, there is no usable upstream version of gz-cmake2 and we are in the process of updating all Gazebo packages to be directly vendorable. In the meantime, switch the current Gazebo vendor packages in ROS 2 core to vendor unconditionally.