-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize like and download queries for models and worlds #16
Conversation
Update model and worlds like handlers to not return total likes.
Thanks! From the top of my head some changes will be necessary. |
Thanks for the changes Alejo. We should make the |
Edit: this was due to an issue on my local setup. Tests failing are in fact due to changes made in this PR. Will fix tests here instead. |
Got it, thanks. Let me know if there's anything I can do to help. |
Add delta parameter to increase/decrease like and download methods. Signed-off-by: Alejo Carballude <alejocarballude@gmail.com>
Signed-off-by: Alejo Carballude <alejocarballude@gmail.com>
Signed-off-by: Alejo Carballude <alejocarballude@gmail.com>
Queries used to update like and download counts for models and worlds have been updated to use SQL expressions instead of computing and updating values inside Fuel. This change improves
like
endpoint performance and also removes the considerable cpu spike when downloading models.One important note is that using an expression to update the value does not return the total like/download count. This value was previously returned by the endpoints and this is no longer the case. I will double check that this does not impact our app client.