Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with reset buttons #507

Open
osrf-migration opened this issue Feb 15, 2013 · 13 comments
Open

issues with reset buttons #507

osrf-migration opened this issue Feb 15, 2013 · 13 comments
Labels

Comments

@osrf-migration
Copy link

Original report (archived issue) by Maurice Fallon (Bitbucket: mauricefallon).


  • pressing the "Reset Model Poses" button doesnt set velocites to zero - so if robot is moving (e.g. falling over) when this is pressed then it will continue with these velocites.
    This makes the button not very useful - please add velocity reset

  • pressing the "Reset World" button resets the entire world - including SIM TIME! This smashes ROS interaction as the ROS core assumes incrementally increasing time.
    Please do not reset the sim time

@osrf-migration
Copy link
Author

Original comment by Thomas Koletschka (Bitbucket: thomasko).


Additionally "Reset Model Poses" only resets the robot's pose but not the configuration. While this corresponds to what the button title suggests it makes the button kind of useless as the robot will be reset to whatever configuration it was in before which is usually not an ideal one.
I guess "Reset World" was made for this purpose (although I'm not sure why I would want to reset a robot with a different configuration, but I guess there's use cases) but it also kills the controllers (due to resetting sim time I suppose) so the robot is useless afterwards.

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


See pull request #316. This sets the velocities to zero when calling Reset Model Poses.

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • changed version from "1.5" to "None"

@osrf-migration
Copy link
Author

Original comment by John Hsu (Bitbucket: hsu, GitHub: hsu).


So currently, reset model poses will reset velocities to zero, but will not reset all link poses (so it will not disturb running controllers, yet it will not recover from exploded simulation). We should add yet another "reset all but time" function, for recovering from NaN's and keep time running so user do not have to restart controllers, which is hard to do sometimes without restarting the entire simulation (consider reloading plugins).

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • changed state from "new" to "on hold"

Until after June, 2013.

@osrf-migration
Copy link
Author

Original comment by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033).


  • changed state from "on hold" to "open"

@osrf-migration
Copy link
Author

Original comment by Peter Lehner (Bitbucket: peter_lehner).


I am confused. This issue was fixed partially in pull request #316 and merged into the default branch. But in the current default version the changes are gone. What happened?

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


I think the code has been moved into the Model class. Look at Model::Reset, and Model::ResetPhysicsStates()

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • set version to "all"

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • changed state from "open" to "new"

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


  • set component to "physics"

@osrf-migration
Copy link
Author

Original comment by Jack Liu (Bitbucket: jacknlliu).


Can gazebo reset world without resetting sim time in gazebo7 or gazebo9?

@osrf-migration
Copy link
Author

Original comment by Andrew Holliday (Bitbucket: lommmzar).


I just wanted to chime in and say that this issue is still present in Gazebo 8. This is a major problem. I'm a grad student in a robotics lab and we're trying to run long-term, many-episode robot learning experiments using Gazebo and ROS. This is made very inconvenient by the fact that occasionally our robot's limbs fall off during an episode, and using reset_world puts the robot's body back at the origin but doesn't put its arms back on. Reset_simulator isn't an option because it causes various other ROS modules to crash, complaining that ROS time went backwards. The only option is for us to kill the entire gazebo-and-ROS-and-learning-agent system and restart from the last checkpoint - meaning we have to periodically check the robot's state visually (making running in headless mode impractical) and then manually reset the entire system.

It is, frankly, astonishing that such a basic feature isn't implemented. I can't imagine that wanting to completely reset a robot's pose without restarting all of ROS is a rare use case, nor can I imagine that this would be difficult to implement. If changing the behaviour of reset_world is a problem for compatibility reasons, couldn't another call, "full_reset_world" or something, be implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant